Adjust for restructured verified-mods.json
#748
Conversation
Each mod version now having its own download link, having a global Thunderstore URL is therefore useless.
At the time, we only know how to install mods from Thunderstore, so we throw an error when extracting mods from elsewhere.
|
bumping so it shows up in the webhook channel and hopefully someone tests it :> |
|
Quick question until I get around testing this, what happens when we merge this PR but not R2Northstar/VerifiedMods#41 ? Does client joining a server that requires verified mods crash or not? Cause with #749 and #751 merged and released only recently, there's still clients that run older versions as the fetch happens before the version gate check, so even if a client would fail version gate, they'd crash before that already due to trying to fetch invalid manifest. |
If we merge the launcher part but not the VerifiedMods counterpart, client won't crash but manifesto parsing will fail (without crashing with #749), thus preventing all mods from being downloaded. |
Ok that's what I was hoping for and would be temporarily be acceptable as MAD is behind a feature flag anyway. This way we can push out this PR even as part of a patch release as the effect is not noticeable by clients under normal circumstances and for dev stuff we can just pass the CLI flag to change the manifest location to that of the PR. |
There was a problem hiding this comment.
Following the instructions, I get "Tried to download a mod that is not verified, aborting" in console.
Do note that this happens with every combination of using the old and new manifesto and using this PR and most recent release.
So most likely the issue is not in the PR itself but maybe the instructions or something else.
|
Setting this PR to draft for now until resolved so that I know which PRs are relevant to be looked at atm. |
So this is due to the local verified mods manifest which is empty (due to |
GeckoEidechse
added
needs code review
ASpoonPlaysGames
added
READY TO MERGE
GeckoEidechse
changed the title
verified-mods.jsonverified-mods.json
Updates the launcher code to deal with adjusted verified mods JSON structure from the default manifest source The idea here is to allow installing mods from other sources than Thunderstore.
This reverts commit d8a1d81.
Updates the launcher code to deal with adjusted verified mods JSON structure defined in R2Northstar/VerifiedMods#41.
The idea here is to allow installing mods from other sources than Thunderstore.
(Somehow) supercedes #642.
(should be merged with R2Northstar/VerifiedMods#41!)
TODOs
Testing
.\NorthstarLauncher.exe -customverifiedurl=https://raw.githubusercontent.com/R2Northstar/VerifiedMods/refactor/include-mod-source-in-version-links/verified-mods.jsonallow_mod_auto_downloadto 1 through console (allow_mod_auto_download 1);sv_cheats 1;script NSFetchVerifiedModsManifesto();script NSDownloadMod("nyami.mp_brick", "1.0.2");Looking at your logs, mod should be downloaded normally.